fix(miner): apply isValidRepoSegment to four normalizeRepoFullName parsers (#7795) - #7882
fix(miner): apply isValidRepoSegment to four normalizeRepoFullName parsers (#7795)#7882RealDiligent wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
1 similar comment
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…rsers (JSONbored#7795) Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7882 +/- ##
==========================================
- Coverage 91.40% 87.72% -3.68%
==========================================
Files 730 92 -638
Lines 74763 21487 -53276
Branches 22815 3733 -19082
==========================================
- Hits 68335 18849 -49486
+ Misses 5385 2460 -2925
+ Partials 1043 178 -865
Flags with carried forward coverage won't be shown. Click here to find out more.
|
loopover-orb
Bot
added
the
gittensor:bug
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 LoopOver is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
|
Closing in favor of a different approach: after #7705, miner-lib-only PRs report 0% patch coverage (vitest records hits under the .js specifier while the diff is .ts-only). Will not push follow-ups on this PR. |
|
Superseded: miner-lib .ts-only diff cannot satisfy codecov/patch after #7705 (confirmed 0% on validate-tests-merge). Not amending — pivoting to a src/engine-safe issue. |
1 participant
Summary
normalizeRepoFullNameparsers that still skippedisValidRepoSegmentafter fix(miner): several owner/repo CLI parsers skip repo-clone.js's path-safety validation #5831/fix(engine): extend #5831's repo-segment path-safety validation to governor/portfolio/worktree stores #7525 (claim-ledgerand siblings already had the guard).contribution-profile-cache,prediction-ledger,replay-snapshot,run-state.miner-claim-ledger: reject../etc,o/.., ando baz/a.Test plan
Fixes #7795
Made with Cursor